-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lambda filter for earthkit.data.Field objects #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCookie
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
The filter looks good, and is well documentated.
I have left a few comments to be addressed,
- Primarily, we use
pytest
as our test harness, so some of theif __name__ == "__main__"
should be removed.
b8raoult
approved these changes
Dec 18, 2024
b8raoult
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a first prototype implementation of a "lambda filter", i.e. a filter wrapping arbitrary user-defined functions.
Code changes
Added a new
EarthkitFieldLambdaFilter
class. Far from being a complete and truly generic feature but can be improved later.earthkit.data.Field
objects, later we might add similar classes for xarray-based and numpy-based functionsSimpleFilter
or creating a new class).Example config:
Extras
Adapted tests to make a single mars request and use numpy.testing module.