Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Exception" to "ValueError" #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

colligant
Copy link

This PR changes the general "Exception" in api.py to ValueError.
From the python docs:

ValueError:
Raised when an operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError 

In general using "Exception" is a bit ambiguous and not recommended for production.

@FussyDuck
Copy link

FussyDuck commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants