Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: use use C++ std::string::compare in StringContent::compareString #156

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mcakircali
Copy link
Contributor

@mcakircali mcakircali commented Dec 23, 2024

replace strcmp (called in StringContent::compareString method) with string compare()

strcmp returns wrong result
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.74%. Comparing base (2cf7ebe) to head (4b4cf79).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #156      +/-   ##
===========================================
- Coverage    63.74%   63.74%   -0.01%     
===========================================
  Files         1066     1066              
  Lines        55360    55360              
  Branches      4086     4086              
===========================================
- Hits         35289    35287       -2     
- Misses       20071    20073       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcakircali mcakircali changed the title Fixes StringContent::compareString issue on aarch64 arch Feature: use use C++ std::string::compare in StringContent::compareString Dec 23, 2024
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12465027334.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12491477903.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12492033108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants