New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multioplan Context Manager & Pydantic Plans #4

Merged

dsarmany merged 33 commits into develop from feature/multioplan_contextmanager

Nov 19, 2024

Member

HCookie commented Sep 26, 2024 •

edited

Loading

Updates to server setup

Create context manager to set plan

Allows for per server plans in a more pythonic way

Pydantic Configs

Using pydantic dataclasses were made to define how to build a plan

codecov-commenter commented Sep 26, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

HCookie requested review from tmi and dsarmany

October 1, 2024 12:51

HCookie changed the title ~~Multioplan Context Manager~~ Multioplan Context Manager & Pydantic Plans

HCookie self-assigned this

Member Author

HCookie commented Oct 1, 2024 •

edited

Loading

#5 will need to be merged first

HCookie force-pushed the feature/multioplan_contextmanager branch from 4bf21ae to 6279ebd Compare

October 2, 2024 15:53

HCookie requested review from corentincarton and oiffrig

October 2, 2024 15:53

tmi reviewed

View reviewed changes

multiopython/_version.py Outdated Show resolved Hide resolved

tmi reviewed

View reviewed changes

multiopython/plans/actions.py Outdated Show resolved Hide resolved

tmi reviewed

View reviewed changes

multiopython/plans/actions.py Outdated Show resolved Hide resolved

tmi reviewed

View reviewed changes

multiopython/plans/plans.py Outdated Show resolved Hide resolved

tmi reviewed

View reviewed changes

multiopython/plans/utils.py Outdated Show resolved Hide resolved

HCookie requested a review from tmi

October 3, 2024 09:49

tmi reviewed

View reviewed changes

multiopython/plans/actions.py Outdated Show resolved Hide resolved

tmi commented Oct 7, 2024

just ftr, now looking good from my PoV (ie, including the pydantic parts, but not including all the multio business).

dsarmany force-pushed the feature/multioplan_contextmanager branch from 1bf1a5e to 764a46c Compare

October 8, 2024 10:33

HCookie force-pushed the feature/multioplan_contextmanager branch 3 times, most recently from f1d2adb to cb40e88 Compare

October 15, 2024 08:47

HCookie requested a review from MircoValentiniECMWF

October 18, 2024 08:08

HCookie added 8 commits

November 19, 2024 10:28


          Feature multioplan contextmanager

82f7330

 - Add context manager to multiopython/utils.py
 - Add tests for the context manager


          Add Pydantic Plans

40a717f


          Improve docs and tests

f0b8a39


          Update toml

e28e720


          Fix missing Sink

0edef42

 - Remove Self


          Extend tests

edde29a


          Code-review changes

969e5a0

 - Use discriminators
 - Use default_factory


          Fix flake8 on tests

48e0dc9

HCookie and others added 25 commits

November 19, 2024 10:28


          Fix test with Config

b6762fa


          Add further tests

e450873


          Update dependencies

fb69596


          Fix yaml -> pyyaml

709c646


          Fix str Field

0f7d877


          Add other client keys

85a3677


          Fix rebase mix-ups: rename multiopython to multio

b549aa0


          Fix: Remove aliases on types

bfe03f9


          Fix: Change FDB config to str not dict

aa4c885


          Feature: Add atlas to encode

e3fffdc


          Fix: Use Path for type checking

7f7e1ef


          Fix: run black

e608e79


          Updates from multio.cc poking

553000d


          Ran black

aca62e9


          Revert change to Path

130250b


          Force FDB config to be dictionary

28c16b1


          Run black/isort

f6a3cee


          Remove SingleField as sink

b4b90d6


          Seperate Client & Server, and add Collection

f590012


          Allow context manager to distinguish between Client and Server

341dd6c


          Remove unused import

42eefa1


          Update example

9ccb493


          Force type to be static in actions

a7e3b61


          Add examples

095a0b7


          Remove unused import

2dc28b8

dsarmany force-pushed the feature/multioplan_contextmanager branch from eb8fa4a to 2dc28b8 Compare

November 19, 2024 10:33

FussyDuck commented Nov 19, 2024 •

edited

Loading

All committers have signed the CLA.

dsarmany approved these changes

View reviewed changes

Collaborator

dsarmany left a comment

This is great. Thank you, Harrison.

dsarmany merged commit 9cd33b5 into develop

96 of 97 checks passed

dsarmany deleted the feature/multioplan_contextmanager branch

November 19, 2024 10:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tmi tmi left review comments

dsarmany dsarmany approved these changes

corentincarton Awaiting requested review from corentincarton

oiffrig Awaiting requested review from oiffrig

MircoValentiniECMWF Awaiting requested review from MircoValentiniECMWF

Labels

None yet