Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove unclear auto behaviour #8

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Dec 5, 2024

This PR removes some unclear automatic behaviour of the pydantic plans which were added.

  • Auto add sinks
  • Extra args being allowed

@HCookie HCookie changed the base branch from main to develop December 5, 2024 13:37
@dsarmany dsarmany force-pushed the fix/remove-unclear-auto-behaviour branch from e6f22c1 to e45b693 Compare December 12, 2024 16:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 31.82%. Comparing base (11bdaa8) to head (9325864).

Files with missing lines Patch % Lines
multio/plans/plans.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
- Coverage    32.53%   31.82%   -0.72%     
===========================================
  Files           15       15              
  Lines          713      707       -6     
===========================================
- Hits           232      225       -7     
- Misses         481      482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsarmany dsarmany merged commit 1249cbb into develop Dec 17, 2024
93 of 100 checks passed
@dsarmany dsarmany deleted the fix/remove-unclear-auto-behaviour branch December 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants