Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/multiple fdb instances #18

Closed
wants to merge 1 commit into from
Closed

Enhancement/multiple fdb instances #18

wants to merge 1 commit into from

Conversation

geier1993
Copy link

PR for feature request #17

Still needs testing and discussion

@geier1993 geier1993 linked an issue Mar 18, 2024 that may be closed by this pull request
Allow using multiple FDB instances with different FDB_HOME/FDB_CONFIG_FILE #17
Closed
@FussyDuck
Copy link

FussyDuck commented Mar 18, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@geier1993 geier1993 changed the base branch from master to develop March 18, 2024 08:42
@geier1993 geier1993 marked this pull request as draft March 18, 2024 08:57
simondsmart
simondsmart reviewed Mar 19, 2024
View reviewed changes
pyfdb/pyfdb.py
if config_path is None:
lib.fdb_new_handle(fdb)
else:
if type(config_path) is str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My instinct is that this is not the right way to do this. I think we probably want to support the Config object (or at the least a LocalConfiguration) natively in the C API, and accept that as an argument.

We also need to handle the userConfiguration correctly.

@geier1993 - can you recall what (if any) support exists for the LocalConfig object via C APIs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no C API for eckit AFAIK.

@tbkr
Copy link
Collaborator

tbkr commented Nov 8, 2024

This should now be fixed with #25. Feel free to reopen in case the feature isn't fully covering your requirements.

@tbkr tbkr closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simondsmart simondsmart simondsmart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow using multiple FDB instances with different FDB_HOME/FDB_CONFIG_FILE
4 participants
@geier1993 @FussyDuck @tbkr @simondsmart