Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datareader.size #37

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add datareader.size #37

merged 2 commits into from
Nov 19, 2024

Conversation

ChrisspyB
Copy link
Member

Depends on PR: ecmwf/fdb#50

Add size to datareader. This allows nice things like:

    dh = fdb1.retrieve(request)
    blob = dh.read() # no argument now reads whole handle.
    fdb2.archive(blob)
    fdb2.flush()

@ChrisspyB ChrisspyB requested review from TomHodson and tbkr November 18, 2024 15:42
@FussyDuck
Copy link

FussyDuck commented Nov 18, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (0d6c2a4) to head (48af9a8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #37   +/-   ##
========================================
  Coverage    94.77%   94.77%           
========================================
  Files            3        3           
  Lines          134      134           
========================================
  Hits           127      127           
  Misses           7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TomHodson TomHodson merged commit aa78558 into develop Nov 19, 2024
101 checks passed
@TomHodson TomHodson deleted the feature/datareader-size branch November 19, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants