Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] App components #182

Open
7 of 12 tasks
leomp12 opened this issue Mar 22, 2020 · 0 comments
Open
7 of 12 tasks

[REFACTOR] App components #182

leomp12 opened this issue Mar 22, 2020 · 0 comments
Labels
3:hard Not so easy, but we can take care vue New feature or fix for some Vue component

Comments

@leomp12
Copy link
Member

leomp12 commented Mar 22, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Components should be available in a unique package to reuse and make easier/predictable customization with Webpack aliases.

Describe the solution you'd like
Put all Vue components together on @ecomplus/storefront-components package, then import it properly.

Describe alternatives you've considered
N/A

Additional context
It's the continuation of #167

TODOs [WIP]

While refactoring, we should also:

  • Fix components to use @ecomplus/i18n (in place of internal dictionary);
  • Adapt for @ecomplus/storefront-twbs v5:
    • No more bootstrap-vue, default Bootstrap 4 + jQuery plugins instead (:heavy_check_mark: done);
    • Some utility classes removed;
    • New additional CSS vars;

Components

  • DiscountApplier
  • LoginBlock
  • TheAccount
  • AddressForm
  • AccountAddresses
  • AccountForm
  • OrdersList
  • TheCart
  • TheCheckout
  • TheOrder
  • TheConfirmation
  • ...
@leomp12 leomp12 added 2:medium Not dificult at all enhancement New feature or request vue New feature or fix for some Vue component labels Mar 22, 2020
@leomp12 leomp12 changed the title [REFACTOR] Storefront App components [REFACTOR] Storefront App Mar 22, 2020
@leomp12 leomp12 changed the title [REFACTOR] Storefront App [REFACTOR] Storefront App v2 Mar 22, 2020
@leomp12 leomp12 changed the title [REFACTOR] Storefront App v2 [REFACTOR] App components Mar 22, 2020
@leomp12 leomp12 added 3:hard Not so easy, but we can take care and removed 2:medium Not dificult at all labels Mar 22, 2020
@leomp12 leomp12 added help wanted Extra attention is needed and removed enhancement New feature or request labels Mar 23, 2020
@leomp12 leomp12 removed the help wanted Extra attention is needed label Apr 3, 2020
leomp12 added a commit that referenced this issue Apr 22, 2020
@leomp12
feat(discount-applier): add DiscountApplier component 🎉
f4f1eb3 
automatically apply discount by utm or item combinations if any

support inserting discount coupon

#182

#201
leomp12 added a commit that referenced this issue Apr 22, 2020
@leomp12
feat(login-block): add new LoginBlock component 🎉
3e72b87 
social login with popup

shows login info ('your account is used for...')

login with email + doc number (cpf, cnpj)

#201

#182
leomp12 added a commit that referenced this issue Apr 23, 2020
@leomp12
refactor(components): update all components css class names
a1e109b 
#182
Raullages added a commit to Raullages/storefront that referenced this issue Jun 6, 2020
@Raullages
feat(the-cart): add TheCart component
7d98d79 
ecomplus#182
@Raullages Raullages mentioned this issue Jun 6, 2020
Merged
Raullages added a commit to Raullages/storefront that referenced this issue Jun 8, 2020
@Raullages
feat(the-cart): add TheCart component
feb9a9e 
ecomplus#182
leomp12 added a commit that referenced this issue Jun 23, 2020
@Raullages @leomp12
feat(the-cart): add TheCart component (#248)
2116548 
* feat(the-cart): add TheCart component

#182

* feat(the-cart): fix feat recent add in (EcCart)

* feat(the-cart): fix n feat EcCart refactoring

* feat(the-cart): fix n feat EcCart refactoring

* feat(the-cart): fix apply discount coupon

* feat(the-cart): fix names var n remove forceupdate

Co-authored-by: Leonardo Matos <leomp120894@gmail.com>
This was referenced Jun 25, 2020
Merged
Merged
@Raullages Raullages mentioned this issue Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3:hard Not so easy, but we can take care vue New feature or fix for some Vue component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leomp12 @Raullages