[impr-OpenMage#395] Duplicate case expressions in some core files

edannenberg · Apr 1, 2019 · a679294 · a679294
1 parent 4b75f79
commit a679294
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/app/code/core/Mage/Adminhtml/controllers/Report/SalesController.php b/app/code/core/Mage/Adminhtml/controllers/Report/SalesController.php
@@ -409,9 +409,6 @@ protected function _isAllowed()
             case 'coupons':
                 return $this->_getSession()->isAllowed('report/salesroot/coupons');
                 break;
-            case 'shipping':
-                return $this->_getSession()->isAllowed('report/salesroot/shipping');
-                break;
             case 'bestsellers':
                 return $this->_getSession()->isAllowed('report/products/bestsellers');
                 break;

diff --git a/lib/Zend/Search/Lucene/Search/QueryToken.php b/lib/Zend/Search/Lucene/Search/QueryToken.php
@@ -214,12 +214,10 @@ public function __construct($tokenCategory, $tokenText, $position)
                 }
                 break;
 
-            case self::TC_NUMBER:
-                $this->type = self::TT_NUMBER;
-
             default:
                 #require_once 'Zend/Search/Lucene/Exception.php';
                 throw new Zend_Search_Lucene_Exception('Unrecognized lexeme type: \'' . $tokenCategory . '\'');
+                break;
         }
     }
 }