Support building with mtl-2.3.* (GHC 9.6)
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mtl-2.3.*` no longer re-exports `Control.Monad` from `Control.Monad.State`, which breaks some code in `hobbits`. This is easily fixed by tightening up the imports a bit.
On GHC 8.6 or later, `TypeInType` is simply an alias for `DataKinds` + `PolyKinds`. What's more, `TypeInType` emits deprecation warnings with GHC 9.6 or later, so this patch guards the use of `TypeInType` behind CPP to avoid the warnings.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 20, 2023
Making SAW build with GHC 9.6 is almost entirely a matter of being more precise with `mtl`-related imports to account for `mtl-2.3.1` not re-exporting as many identifiers from `Control.Monad`, `Control.Monad.IO.Class`, etc. I have also bumped the following submodules and `source-repository-package`s to allow them to build with GHC 9.6: * `cryptol`: GaloisInc/cryptol#1572 * `hobbits`: eddywestbrook/hobbits#9
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 20, 2023
Making SAW build with GHC 9.6 is almost entirely a matter of being more precise with `mtl`-related imports to account for `mtl-2.3.1` not re-exporting as many identifiers from `Control.Monad`, `Control.Monad.IO.Class`, etc. I have also bumped the following submodules and `source-repository-package`s to allow them to build with GHC 9.6: * `cryptol`: GaloisInc/cryptol#1572 * `hobbits`: eddywestbrook/hobbits#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mtl-2.3.*no longer re-exportsControl.MonadfromControl.Monad.State, which breaks some code inhobbits. This is easily fixed by tightening up the imports a bit.