Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rp contract to use gelato functions #64

Open
wants to merge 2 commits into
base: tmigone/recurring-payments
Choose a base branch
from

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Dec 5, 2023

Changes

  • Updated Gelato contracts to latest version
  • Removed treasury management from RP contract
  • Added script to add funds with 1Balance (withdraw script missing since it's more involved, will add when we resume work on RP)
  • Added Proxy module to tasks (though we don't use the dedicated msg sender feature, the module is now required)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (tmigone/recurring-payments@43e6ce2). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             tmigone/recurring-payments      #64   +/-   ##
=============================================================
  Coverage                              ?   90.43%           
=============================================================
  Files                                 ?        9           
  Lines                                 ?      324           
  Branches                              ?       96           
=============================================================
  Hits                                  ?      293           
  Misses                                ?       31           
  Partials                              ?        0           
Flag Coverage Δ
unittests 90.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone requested review from pcarranzav and Maikol December 5, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants