Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove query rewrites #900

Open
Theodus opened this issue Jul 22, 2024 · 1 comment
Open

remove query rewrites #900

Theodus opened this issue Jul 22, 2024 · 1 comment
Assignees

Comments

@Theodus
Copy link
Member

Theodus commented Jul 22, 2024

After release 2.1.1, client query rewrites are only required for inserting the probe for block data. Ideally we would remove the error-prone rewrite code in favor of independent queries to indexers for that block data. These queries can be far less frequent than client queries typically are for each subgraph chain.

@Theodus Theodus self-assigned this Jul 22, 2024
@Theodus Theodus removed their assignment Nov 5, 2024
@Theodus Theodus self-assigned this Nov 18, 2024
@Theodus
Copy link
Member Author

Theodus commented Nov 18, 2024

This was attempted in release 24.2.0. However, it requires graphprotocol/indexer-rs#494 to avoid regressions.

Theodus added a commit to graphprotocol/graph-node that referenced this issue Nov 25, 2024
This adds a `graph-indexed` header to query responses. The header value contains the block hash, number, and timestamp for the most recently processed block in the subgraph. This avoids the need to rewrite all queries to include `_meta { block { hash number timestamp } }` in either the indexer-service or gateway.

Related: edgeandnode/gateway#900, graphprotocol/indexer-rs#494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant