refactor(graph-gateway): add query selector extractor #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am putting this PR in draft for now. |
LNSD
force-pushed
the
lnsd/split-query-handler-fn
branch
from
768151c to
5726311
Compare
|
Closing this PR in favor of #563 approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are a major refactoring of the client query handler function. The aim is to simplify the logic in the handler at the expense of a few duplicated lines of code (tracing and metrics).
Pathextractor to customize the rejection errors. TheQuerySelectorextractor rejections are GraphQL error responses.selectorfield within the query selector extractor.