refactor(graph-gateway): add query selector extractor and check #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
changed the title
LNSD
commented
Jan 25, 2024
Comment on lines
-88
to
-98
| // This is very useful for investigating gateway logs in production | ||
| let selector = match &resolved_deployments { | ||
| Ok((_, Some(subgraph))) => subgraph.id.to_string(), | ||
| Ok((deployments, None)) => deployments | ||
| .iter() | ||
| .map(|d| d.id.to_string()) | ||
| .collect::<Vec<_>>() | ||
| .join(","), | ||
| Err(_) => "".to_string(), | ||
| }; | ||
| span.record("selector", tracing::field::display(selector)); |
There was a problem hiding this comment.
This code snippet has been "moved" to the QuerySelector extractor:
This is equivalent since we are setting either the SubgraphId or the DeploymentId depending on the selector.
|
Aiming to merge this post v17.1.0 release |
LNSD
force-pushed
the
lnsd/query-selector-extract-and-check
branch
from
07076bc to
6542b59
Compare
|
Feel free to merge this now. I'm probably not finishing up the release until Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #561, where the query handler method is not split into two. This approach uses an "enum" extractor to differentiate when handling subgraph or deployment queries.
QuerySelectorextractorselectorfield within the extractor