Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebAuthn and Magic Links in auth-remix #899

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Conversation

scotttrinh
Copy link
Collaborator

Similar to #897

Going to do some testing before opening this up for review, but it's a pretty straightforward port from the nextjs work.

@scotttrinh scotttrinh marked this pull request as ready for review March 21, 2024 12:58
Base automatically changed from 877-auth-nextjs to master March 21, 2024 14:51
@scotttrinh scotttrinh merged commit 8ea7932 into master Mar 21, 2024
7 of 8 checks passed
@scotttrinh scotttrinh deleted the 877-auth-remix branch March 21, 2024 15:16
@JesseFarebro
Copy link

JesseFarebro commented Apr 2, 2024

Tried this out and ran into a problem where calling signupWithWebAuthn results in this issue: remix-run/remix#4414. Problem being that two requests are made in succession, 1) webauthn/register and if successful 2) token. The call to token is what results in a socket hang up.

Perhaps you could allow for additional headers to be passed through to the fetch call or keep-alive could be the default?

@scotttrinh
Copy link
Collaborator Author

@JesseFarebro

What version of EdgeDB Server are you running? We had a bug that was fixed in 5.0b2 where we were not setting the Connection: close header and just ending the connection that also showed a socket hang up error but that was fixed by sending that (ostensibly optional) header in the server. If you're on an older beta, or an older nightly, can you try with the latest beta?

@JesseFarebro
Copy link

Thanks for the prompt reply @scotttrinh. I'm on 5.0-beta.2+96c7381, should I move to one of the nightly builds?

@scotttrinh
Copy link
Collaborator Author

@JesseFarebro

Oh, it looks like it hasn't gotten into a beta yet. I'll poke the release team to see when the next beta is released. It is definitely in the latest nightlies, but I don't want you to have to switch the nightly just to get this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants