-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebAuthn and Magic Links in auth-remix #899
Conversation
1070313
to
7076263
Compare
8b06184
to
9e335d0
Compare
The response type is determined but what your app's WebAuthn handler returns, and it _won't_ be SignupResponse.
This catches even optional options
9e335d0
to
d7576db
Compare
Tried this out and ran into a problem where calling Perhaps you could allow for additional headers to be passed through to the |
What version of EdgeDB Server are you running? We had a bug that was fixed in 5.0b2 where we were not setting the |
Thanks for the prompt reply @scotttrinh. I'm on |
Oh, it looks like it hasn't gotten into a beta yet. I'll poke the release team to see when the next beta is released. It is definitely in the latest nightlies, but I don't want you to have to switch the nightly just to get this fix. |
Similar to #897
Going to do some testing before opening this up for review, but it's a pretty straightforward port from the nextjs work.