Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F# option interop #58

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Fix F# option interop #58

merged 2 commits into from
Jul 13, 2023

Conversation

quinchs
Copy link
Collaborator

@quinchs quinchs commented Jul 11, 2023

Summary

This PR fixes both #55 and #54 by:

  • Extracting the wrapping type of option when visiting codecs
  • Extracting the value from options when serializing arguments
  • Fixing anonymous types with option types (closely related to Fix anonymous type deserialization #56)

cc @Darkle

@quinchs quinchs requested a review from nsidnev July 11, 2023 17:41
@quinchs quinchs merged commit fa524cb into dev Jul 13, 2023
2 checks passed
@quinchs quinchs deleted the fix/fsharp-option-interop branch July 13, 2023 16:35
This was referenced Jul 13, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsidnev nsidnev nsidnev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quinchs @nsidnev