Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change subscription topics to receive any event from device LLRP #202

Conversation

marcpfuller
Copy link
Contributor

fixes: #201

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-rfid-llrp-inventory/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)NA
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)NA

Testing Instructions

  1. start edgex
  2. start app-rfid-llrp
  3. start llrp simulator
  4. start device-rfid-llrp
  5. open browser to localhost:59711
  6. verify that app-rfid-llrp finds device reader
  7. verify that inventory snap shot is not empty

New Dependency Instructions (If applicable)

fixes: edgexfoundry#201

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
@marcpfuller marcpfuller force-pushed the messagebus_topic_reader_notification branch from 28c3a07 to f53ad71 Compare May 24, 2023 22:50
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit ad72238 into edgexfoundry:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[App LLRP] Subscribe topic for ReaderEventNotification incorrect
2 participants