Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing device services doc pages #1225

Merged

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell force-pushed the add-missing-device-services branch from 9248219 to 37d12d8 Compare September 18, 2023 22:42
@lenny-goodell
Copy link
Member Author

@cloudxxx8 , @FelixTing , @lindseysimple , please review.

Copy link
Member

@jpwhitemn jpwhitemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
placeholders look a little odd, but it helps to provide consistency of the menus. Obviously we need some additional docs here, but works for now.

@lenny-goodell lenny-goodell merged commit 847dc63 into edgexfoundry:main Sep 19, 2023
1 check passed
@lenny-goodell lenny-goodell deleted the add-missing-device-services branch September 19, 2023 22:59
edgex-jenkins added a commit that referenced this pull request Sep 19, 2023
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants