Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow profileName to be empty string in Device #901

Closed
cloudxxx8 opened this issue Jun 28, 2024 · 0 comments · Fixed by #902
Closed

Allow profileName to be empty string in Device #901

cloudxxx8 opened this issue Jun 28, 2024 · 0 comments · Fixed by #902
Assignees
@jinlinGuan
Labels
enhancement New feature or request

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core-metadata, device-services

Description [REQUIRED]

Currently, Device and DeviceProfile have hard dependency, and the profileName field of Device is required.
However, there are some scenarios need empty profile. Currently, users have to create a fake profile to achieve that.
Deivces may be created first with empty profiles, and the profile can be scanned or generated by some tools for some protocols, such as OPC-UA and BACnet.

Describe the solution you'd like

Allow Device can be created or updated with the empty string of profileName.
If this case, we need to modify Device Services to do nothing if there is any requests sent to the Device with emtpy profiles.
@cloudxxx8 cloudxxx8 added the enhancement New feature or request label Jun 28, 2024
jinlinGuan added a commit to jinlinGuan/go-mod-core-contracts that referenced this issue Jul 1, 2024
@jinlinGuan
feat!: Allow empty profileName in Device
3b67702 
closed edgexfoundry#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
jinlinGuan added a commit to jinlinGuan/go-mod-core-contracts that referenced this issue Jul 1, 2024
@jinlinGuan
feat!: Allow empty profileName in Device
ad1b3ae 
BREAKING CHANGE: Allow empty profileName in Device, and set AdminState as Locked and OperatingState as Down by default

closed edgexfoundry#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@jinlinGuan jinlinGuan mentioned this issue Jul 1, 2024
Merged
5 tasks
@cloudxxx8 cloudxxx8 mentioned this issue Jul 1, 2024
Closed
jinlinGuan added a commit to jinlinGuan/device-sdk-go that referenced this issue Jul 1, 2024
@jinlinGuan
feat: Allow empty profileName in Device
3754d40 
refer to edgexfoundry/go-mod-core-contracts#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@jinlinGuan jinlinGuan mentioned this issue Jul 1, 2024
Merged
5 tasks
jinlinGuan added a commit to jinlinGuan/device-sdk-go that referenced this issue Jul 2, 2024
@jinlinGuan
feat: Allow empty profileName in Device
b7a2f1e 
refer to edgexfoundry/go-mod-core-contracts#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this issue Jul 2, 2024
@jinlinGuan
feat: Allow empty profileName in Device
b1cad70 
refer to edgexfoundry/go-mod-core-contracts#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this issue Jul 2, 2024
@jinlinGuan
feat: Allow empty profileName in Device
3b64f17 
refer to edgexfoundry/go-mod-core-contracts#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this issue Jul 2, 2024
@jinlinGuan
feat(metadata): Allow empty profileName in Device
702ba25 
refer to edgexfoundry/go-mod-core-contracts#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@jinlinGuan jinlinGuan mentioned this issue Jul 2, 2024
Merged
5 tasks
jinlinGuan added a commit to jinlinGuan/device-virtual-go that referenced this issue Jul 2, 2024
@jinlinGuan
feat: Allow empty profileName in Device
ad92c84 
refer to edgexfoundry/go-mod-core-contracts#901

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@jinlinGuan jinlinGuan mentioned this issue Jul 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinlinGuan jinlinGuan

Labels
enhancement New feature or request
Projects
Technical WG
Status: Odessa Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow empty profileName in Device jinlinGuan/go-mod-core-contracts
2 participants
@cloudxxx8 @jinlinGuan