Remove media_type_parameters
#778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a break, but will give this a once-over with fresher eyes in a couple hours and merge, then deploy alongside #777. |
Closed
Mr0grog
deleted the
752-pedantic-management-of-media-types-is-not-useful
branch
Mr0grog
added a commit
that referenced
this pull request
Nov 13, 2020
This was supposed to be part of #778, but I forgot to commit the file!
Mr0grog
added a commit
that referenced
this pull request
Nov 13, 2020
This was supposed to be part of #778, but I forgot to commit the file!
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Version#media_type_parametersfield (it wasn’t useful) and changes theVersions#media_typefield to a cleaned-up, normalized, canonicalized field (instead of just reflecting whatever the HTTP response’sContent-Typeheader had). This makes it dramatically more useful without removing canonical information stored elsewhere.Fixes #752.