Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor several poorly named fields on Version #856

Merged
merged 9 commits into from
Jun 17, 2021
Merged

Refactor several poorly named fields on Version #856

merged 9 commits into from
Jun 17, 2021

Commits on Jun 5, 2021

  1. Update documentation to show new Version fields

    @Mr0grog
    Mr0grog committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    afbdd69 View commit details
    Browse the repository at this point in the history

  2. Add migration to rename fields

    @Mr0grog
    Mr0grog committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    3c883b7 View commit details
    Browse the repository at this point in the history

  3. Update the code to handle renamed version fields

    @Mr0grog
    Mr0grog committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    a3c16f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. OBEY RUBOCOP (mostly)

    @Mr0grog
    Mr0grog committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    bb9e02e View commit details
    Browse the repository at this point in the history

  2. Add data migration

    @Mr0grog
    Mr0grog committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    2b3af40 View commit details
    Browse the repository at this point in the history

  3. Don't rename content_length

    @Mr0grog
    Mr0grog committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    68f0ab5 View commit details
    Browse the repository at this point in the history

  4. Update seed data to use new field names 

    I did this using jq:

    $ cat db/seed_import.json | jq -c '. + {body_hash: .version_hash, body_url: .uri} | del(.version_hash) | del(.uri)' > db/seed_import.new.json
    $ mv db/seed_import.new.json db/seed_import.json
    @Mr0grog
    Mr0grog committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    a33f3d9 View commit details
    Browse the repository at this point in the history

  5. Add tests for backwards-compatible imports

    @Mr0grog
    Mr0grog committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    63a0337 View commit details
    Browse the repository at this point in the history

  6. OBEY RUBOCOP

    @Mr0grog
    Mr0grog committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    675df92 View commit details
    Browse the repository at this point in the history