Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to send a request with a query as follow:
which is to encode easy using
Plug.Conn.Query.encode
, as%{foo: [1, 2]}
yields the correct result.However, it seems to be impossible to pass an already encoded query to
HTTPoison
,as
URI.encode_query
fails.Of course, we can append directly to the URL, but as the
params
option already exists,I think it would be nicer to support this case as well.
This patch keeps the previous behavior when the query is not a binary, and avoid
trying to reencode it when it is already a binary.
Thank you.