fix: modifications to remove wanings updated enrollment service #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fine tuning code and readme Improved enrollment service API Stopping inline iframe usage for now
ziafazal
requested review from
hinakhadim and
Talha-Rizwan
and removed request for
hinakhadim
| function updateIframeSrc(href, liText) { | ||
| if (liText.includes('AnyWindow')) { | ||
| function updateIframeSrc(href, launchMethod) { | ||
| // TODO: Uncomment the code below when we have figured out a workaround of limitations imposed by |
There was a problem hiding this comment.
There is no commented code here.
| {% if index_page_url %} | ||
| <h5 class="xblock-title mb-2"> {% trans "Available Assignables:" %}</h5> | ||
| <!-- <h5 class="xblock-title mb-2"> {% trans "Available Assignable Units:" %}</h5> --> | ||
| <div class="{% if cmi5_xblock.au_has_any_window %}cmi5-nav cmi5-column{% endif %}"> |
There was a problem hiding this comment.
au_has_any_window is not being assigned any value except for default until this comment resolves.
Talha-Rizwan
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
The CMI5 xblock has an installation issue in tutor quince as it doesn't automatically install by tutor mounts add <path/to/xblock>. We can maybe add that in the README troubleshooting section.
Otherwise LGTM. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fine tuning code and readme
Improved enrollment service API
Stopping inline iframe usage for now
Merge checklist:
Check off if complete or not applicable: