Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use-default-language option #53

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

trojczak
Copy link
Collaborator

@trojczak trojczak commented Jul 28, 2023

Fixes: #43

Signed-off-by: Rafał Trójczak <Rafal.Trojczak@makolab.com>
@trojczak trojczak self-assigned this Jul 28, 2023
@trojczak trojczak requested a review from mereolog July 28, 2023 10:39
Copy link
Contributor

@mereolog mereolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this introduces a new option, @trojczak could you update the ReadMe file as well?

@mereolog
Copy link
Contributor

mereolog commented Aug 4, 2023

Also, and more seriously, mvn clean package yields this:

[ERROR] Tests run: 27, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 54.675 s <<< FAILURE! - in org.edmcouncil.rdf_toolkit.writer.SortedRdfXmlWriterTest
[ERROR] shouldUseDefaultSettingsForSerializationOfLiteralsWhenAdditionalSettingsAreNotSet  Time elapsed: 0.015 s  <<< ERROR!
org.edmcouncil.rdf_toolkit.runner.exception.RdfToolkitOptionHandlingException: Source file does not exist: /Users/pawel.garbacz/Documents/edmc/github/edmc/rdf-toolkit/src/test/resources/ontologies/literal/test1.rdf
	at org.edmcouncil.rdf_toolkit.writer.SortedRdfXmlWriterTest.shouldUseDefaultSettingsForSerializationOfLiteralsWhenAdditionalSettingsAreNotSet(SortedRdfXmlWriterTest.java:1119)

[ERROR] shouldUseDefaultSettingsForSerializationOfLiteralsWhenUseDefaultLanguageIsSet  Time elapsed: 0.167 s  <<< ERROR!
org.edmcouncil.rdf_toolkit.runner.exception.RdfToolkitOptionHandlingException: Source file does not exist: /Users/pawel.garbacz/Documents/edmc/github/edmc/rdf-toolkit/src/test/resources/ontologies/literal/test1.rdf
	at org.edmcouncil.rdf_toolkit.writer.SortedRdfXmlWriterTest.shouldUseDefaultSettingsForSerializationOfLiteralsWhenUseDefaultLanguageIsSet(SortedRdfXmlWriterTest.java:1164)

[ERROR] shouldUseDefaultSettingsForSerializationOfLiteralsWhenOverrideLanguageSettingIsSet  Time elapsed: 0.072 s  <<< ERROR!
org.edmcouncil.rdf_toolkit.runner.exception.RdfToolkitOptionHandlingException: Source file does not exist: /Users/pawel.garbacz/Documents/edmc/github/edmc/rdf-toolkit/src/test/resources/ontologies/literal/test1.rdf
	at org.edmcouncil.rdf_toolkit.writer.SortedRdfXmlWriterTest.shouldUseDefaultSettingsForSerializationOfLiteralsWhenOverrideLanguageSettingIsSet(SortedRdfXmlWriterTest.java:1139)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   SortedRdfXmlWriterTest.shouldUseDefaultSettingsForSerializationOfLiteralsWhenAdditionalSettingsAreNotSet:1119 » RdfToolkitOptionHandling
[ERROR]   SortedRdfXmlWriterTest.shouldUseDefaultSettingsForSerializationOfLiteralsWhenOverrideLanguageSettingIsSet:1139 » RdfToolkitOptionHandling
[ERROR]   SortedRdfXmlWriterTest.shouldUseDefaultSettingsForSerializationOfLiteralsWhenUseDefaultLanguageIsSet:1164 » RdfToolkitOptionHandling
[INFO] 
[ERROR] Tests run: 85, Failures: 0, Errors: 3, Skipped: 2

@mereolog mereolog assigned mereolog and unassigned trojczak Feb 5, 2024
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
@mereolog mereolog self-requested a review February 5, 2024 09:36
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
@mereolog mereolog merged commit ed5dbae into develop Feb 22, 2024
@mereolog mereolog deleted the 43-add-add-use-default-language-option branch February 22, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to add a default language tag to untyped, untagged strings
3 participants