Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: adding a source faster compatibility source for eox-tenant #37

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

felipemontoya
Copy link
Member

@felipemontoya felipemontoya commented Aug 23, 2022

Description

This PR adds a new config source. This source is a faster implementation of the microsite_V0.

  • V0, will remove a key that is unused by the current version of control center and will then pass that call to configuration_helpers.
  • V1 will not remove the key.
  • V2 will remove the key, but then make a faster call to django settings directly.

Testing instructions

first, add the following config to lms.env.json:

"EOX_THEMING_CONFIG_SOURCES":[
  "from_eox_tenant_microsite_v2",
  "from_django_settings"
],

when using a profiler, the call went from:

Per call: 6.056e-05 | config_sources.py:42(from_eox_tenant_microsite_v0)

to

Per call: 7.453e-06 | config_sources.py:51(from_eox_tenant_microsite_v2)

One order of magnitude faster.

Checklist for Merge

  • Tested in a remote environment -> I suppose you need to apply this in order to test @Alec4r
  • Updated documentation N/A
  • Rebased master/main N/
  • Squashed commits N/

@Alec4r Alec4r merged commit a3b6c38 into master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants