feat: allow validators to choose a reason when disapproving a validation process #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: apply validations to modal of submitting reviews * refactor: show error messages when needed * refactor: apply the needed changes to show reason.name * refactor: improve some variable names to improve readability
dcoa
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the rejection reasons gotten through this endpoint for making the validators able to use them when required to update the status of a validation process to 'Disapproved'
How to test
As courseAutor, submit a validation process
Then, as a validator, take the course to review it
And access to the modal to send a validator review
Here you'll be able to...
Additionals
As courseAuthor: