Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable footer #22

Merged
merged 1 commit into from
Nov 26, 2023
Merged

feat: add configurable footer #22

merged 1 commit into from
Nov 26, 2023

Conversation

dcoa
Copy link
Collaborator

@dcoa dcoa commented Nov 24, 2023

This PR removes the default "Powered by Openedx" logo and leaves no logo by default. However, add LOGO_TRADEMARK_URL and LOGO_TRADEMARK_REDIRECT variables in case a logo is needed.

image

@dcoa dcoa requested a review from a team November 24, 2023 01:52
Copy link

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if you need the new line in the package.json, but the rest looks good. Thanks, Dianis ✨

@dcoa dcoa merged commit 88febef into master Nov 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants