Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update pkg with the latest updates of upstream #8

Merged
merged 64 commits into from
Aug 22, 2024

Conversation

bra-i-am
Copy link

@bra-i-am bra-i-am commented Aug 12, 2024

Description:

This PR updates this package to integrate the latest changes of CSS variables support contained in the upstream PR #689

Merge checklist:

Additional info:

Solved issue #85 from eox-release

arbrandes and others added 30 commits March 20, 2024 13:09
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nedx#676)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 0.27.2 to 0.28.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.28.0/CHANGELOG.md)
- [Commits](axios/axios@v0.27.2...v0.28.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nedx#661)

BREAKING CHANGE: Due to peerDependency upgrade of frontend-build this goes as a breaking change
dcoa added 18 commits June 26, 2024 11:28
chore: update package-lock.json

chore: update package-lock.json take 2

chore: remove console.log statements

fix: ignore system preference change when theme variant set in localstorage

chore: add tests for updates to AppProvider

chore: update react-intl to pass peer dependencies after pinning all deps

chore: split hooks.js up into separate files and begin some related tests

test: add testing to useParagonTheme hooks (openedx#514)

* test: add testing to useParagonThemeCore
* test: add test to useThemeVariants hook
* fix: Paragon definition and remove onload mock
* test: change test message to be clear
@bra-i-am
Copy link
Author

Update

Tests are failing because of a codecov token we can't access, and the commit linter because of an upstream commit that couldn't be modified in the rebase.

@bra-i-am bra-i-am requested a review from dcoa August 12, 2024 14:11
@dcoa
Copy link
Collaborator

dcoa commented Aug 12, 2024

Please drop the temporal commit that adds the dist folder as specified in upstream's PR is there for testing purposes.

Thank you, @bra-i-am

@bra-i-am bra-i-am force-pushed the bc/update-css-variables branch from 29a45d9 to bd1561e Compare August 13, 2024 13:32
@bra-i-am
Copy link
Author

@dcoa: the commit was already dropped

@dcoa
Copy link
Collaborator

dcoa commented Aug 16, 2024

I was thinking that we should leave only the design tokens commits and drop the upstream commits otherwise we are not using version 7.x.x that supposed to be the base.

@bra-i-am sorry for the inconvenience

Update: thinking better and understanding that the only breaking change is frontend-build I will still update the version of frontend-platform to match upstream with the change you already made to make it compatible with our custom version of that library.

@dcoa dcoa force-pushed the bc/update-css-variables branch from 8dc541a to 10171c2 Compare August 20, 2024 04:09
@bra-i-am bra-i-am merged commit f6a8658 into edunext/css-variables-7.1.2 Aug 22, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants