fix: duplicated post annotation #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d3e657e in 1 minute and 28 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_pPPU08NREIVotRY7
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 4 days left in your free trial, upgrade for $20/seat/month or contact us.
| @@ -22,7 +22,6 @@ public class PostController { | |||
| private PostService postService; | |||
|
|
|||
| @Secured("ROLE_TEACHER") | |||
| @PostMapping | |||
| @Operation(summary = "Cria um post") | |||
| @PostMapping | |||
| public ResponseEntity<Post> createPost(@RequestBody @Valid PostDTO post, @PathVariable String id){ | |||
There was a problem hiding this comment.
The @PathVariable String id in the createPost method signature is not defined in the @PostMapping path. This could lead to runtime errors. Consider adding a path variable in the @PostMapping annotation if 'id' is required, or remove it if not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objetivo
Correção urgente de anotação PostMapping duplicada no endpoint de criação de posts
Implementação
Remoção de anotação duplicada
Summary:
This PR removes a duplicated
@PostMappingannotation in thecreatePostmethod of thePostControllerclass to prevent potential runtime errors.Key points:
@PostMappingannotation increatePostmethod ofPostController.Generated with ❤️ by ellipsis.dev