(VolPkg) Add support for transform paths #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of the transform functionality added in #67 and #69 to make working with transforms a little more automatic.
First, the single argument
VolumePkg::transform(id)
andVolumePkg::hasTransform(id)
functions now support constructing a composite transform using the->
operator in the id string. The inverse*
operator is still fully supported. The following will return a composite transform containing the three identified transforms with inversion already applied to the final transform:Second, the two argument
VolumePkg::transform(src, tgt)
function now additionally searches for multi-transform paths between the source and target volumes. Single-transform paths (what the previous implementation returned) are returned as their original transform type. Multi-transform paths are returned as a new, unsimplifiedCompositeTransform
. Paths are returned in order of increasing length and may incorporate inverse transforms which help satisfy the mapping. The returned identifiers follow the form used by the newVolumePkg::transform(id)
implementation:Other changes
push_front
member