Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONT MERGE**DPE-597**DONT MERGE #83

Closed
wants to merge 2 commits into from
Closed

DONT MERGE**DPE-597**DONT MERGE #83

wants to merge 2 commits into from

Conversation

purna2U
Copy link
Contributor

@purna2U purna2U commented Jun 28, 2023

Description: Describe in a couple of sentences what this PR adds

JIRA: Link to JIRA ticket

Dependencies: dependencies on other outstanding PRs, issues, etc.

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@purna2U purna2U requested a review from a team as a code owner June 28, 2023 04:08
@purna2U purna2U changed the title Add files via upload DPE-597 Jun 28, 2023
@purna2U purna2U changed the title DPE-597 DONT MERGE**DPE-597**DONT MERGE Jun 28, 2023
@purna2U purna2U closed this Jun 28, 2023
@purna2U purna2U deleted the purna2U-patch-2 branch June 28, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant