-
Notifications
You must be signed in to change notification settings - Fork 16
Removed unique=True from UserOpenID.claimed_id #1
Conversation
@macdiesel @nedbat I have imported the code from https://code.launchpad.net/django-openid-auth and made this change. Thoughts? |
Btw, it does fix the issue. And as far as I understand in Django 1.4 |
👍 |
@nedbat @doctoryes This needs one more review. |
@symbolist Above, you say you "imported the code from launchpad and made this change." Does this mean you submitted the change upstream to the module itself? Other than this question, looks fine. |
@doctoryes We are planning to change the field to |
👍 |
7efa106
to
dbf4c9b
Compare
Shouldn't this PR be against the 'master' branch instead of the 'upstream' branch? Typically, an 'upstream' branch would reflect the state of the upstream repo - while 'master' would reflect our edX changes. |
I'm going to hold off on merging this until @symbolist comments. |
@doctoryes When I was working on this, master did not have the right commit history, so I pushed the upstream code into the |
https://openedx.atlassian.net/browse/TNL-3664
django-openid-auth has claimed_id = TextField(unique=True). However, TextFields cannot be unique in MySQL: django/django@e8cbc2b
https://docs.djangoproject.com/en/1.8/ref/models/fields/#textfield
https://code.djangoproject.com/ticket/2495
This results in the following error when running migrations:
"django.db.utils.OperationalError: (1170, "BLOB/TEXT column 'claimed_id' used in key specification without a key length")"