Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Upgrading to use python 3.11 #189

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Apr 23, 2024

Adding Python3.11.
Dropped python3.8 support.

@awais786
Copy link
Contributor Author

@feanil Please review this. Coverage is failing.

@feanil
Copy link

feanil commented May 15, 2024

This is in the edx org and specific to edx.org, I can't make any fixes here.

@MichaelRoytman
Copy link
Member

@awais786

Can this pull request be reviewed and merged? We are having some trouble merging Python requirements upgrades due to incompatibility with Python 3.8, so it would be good to upgrade. Thank you.

@awais786
Copy link
Contributor Author

awais786 commented Sep 6, 2024

@awais786

Can this pull request be reviewed and merged? We are having some trouble merging Python requirements upgrades due to incompatibility with Python 3.8, so it would be good to upgrade. Thank you.

@MichaelRoytman its green now. You need to drop the python3.8 runners from github.

@awais786
Copy link
Contributor Author

awais786 commented Sep 8, 2024

@MichaelRoytman you can review and merge.

@MichaelRoytman MichaelRoytman merged commit 45422d1 into edx:main Sep 9, 2024
6 checks passed
@UsamaSadiq UsamaSadiq changed the title feat: Adding python3.11 support. feat!: Upgrading to use python 3.11 Sep 9, 2024
@@ -2,4 +2,4 @@
Django app housing name affirmation logic.
"""

__version__ = '2.3.7'
__version__ = '2.4.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelRoytman @UsamaSadiq Could you bump this version on pip? Please. I need to update edx-opaque-keys in other repos. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Thank you for the ping. I just published a new release. It should be available on PyPI! Please let me know if you need anything else.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@zacharis278 zacharis278 mentioned this pull request Oct 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants