Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build Make target. #219

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

MichaelRoytman
Copy link
Member

@MichaelRoytman MichaelRoytman commented Sep 9, 2024

Description:

This commit removes a line in the upgrade Make target that attempts to delete a file that doesn't exist. The lines that generated the file that is being deleted were deleted in a previous commit.

JIRA:

None.

Pre-Merge Checklist:

  • Updated the version number in edx_name_affirmation/__init__.py if these changes are to be released. See OEP-47: Semantic Versioning.
  • Described your changes in CHANGELOG.rst.
  • Confirmed Github reports all automated tests/checks are passing.
  • Approved by at least one additional reviewer.

Post-Merge:

  • Create a tag matching the new version number.

Copy link

github-actions bot commented Sep 9, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

This commit removes a line in the upgrade Make target that attempts to delete a file that doesn't exist. The lines that generated the file that is being deleted were deleted in a previous commit.
@MichaelRoytman MichaelRoytman force-pushed the michaelroytman/fix-upgrade-make-target branch from fb43ce9 to 4211ce1 Compare September 9, 2024 20:08
@MichaelRoytman MichaelRoytman merged commit 90b4826 into main Sep 9, 2024
6 checks passed
@MichaelRoytman MichaelRoytman deleted the michaelroytman/fix-upgrade-make-target branch September 9, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants