Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

MCKIN-7023 xblock i18n bump versions #1073

Merged
merged 1 commit into from
May 9, 2018

Conversation

pomegranited
Copy link

@pomegranited pomegranited commented May 9, 2018

Cleanup only; no new functionality introduced.

Removes dependencies on temporary branches introduced by #1032.

JIRA tickets: MCKIN-7023

Testing instructions:

Same as #1032

Author notes and concerns:

  1. We are waiting for [MCKIN-2723] Use i18n runtime service to provide translations for HTML templates openedx/xblock-drag-and-drop-v2#154 to merge before the drag-and-drop-v2-new revision can be updated too.

Reviewers

since PRs have merged and new versions tagged.
@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! I've created OSPR-2396 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@mtyaka
Copy link

mtyaka commented May 9, 2018

👍

  • I tested this: I verified that the updated dependencies install and work correctly
  • I read through the code
  • I checked for accessibility issues n/a
  • Includes documentation n/a

@pomegranited
Copy link
Author

The test failures are a known issue on this branch, so merging now.

@pomegranited pomegranited merged commit ee9314d into integration May 9, 2018
@pomegranited pomegranited deleted the MCKIN-7023-xblock-i18n-bump-versions branch May 9, 2018 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants