fix: Remove B2C Subscriptions subs API call #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/SONIC-693/remove-fetch-subs-call
branch
2 times, most recently
from
2502b89 to
43b9ac1
Compare
julianajlk
force-pushed
the
julianajlk/SONIC-693/remove-fetch-subs-call
branch
from
43b9ac1 to
1b70fc2
Compare
julianajlk
force-pushed
the
julianajlk/SONIC-693/remove-fetch-subs-call
branch
from
1b70fc2 to
e4a4acc
Compare
julianajlk
changed the title
grmartin
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONIC-693.
This is a workaround to having to remove all of the subs sagas and reducers, and modify the files that are in common with order history. For context, the new Order History is set to launch in ~3 weeks.
Previously the assumption was that since this MFE is being replaced and handles API errors gracefully, and the BE subs would be disabled in the future, I only removed subscriptions history from being displayed but not all of the logic around fetching subs. But it looks like we might not get to the infra work for BE subs soon enough, and there is some maintenance we want to avoid (ie. https://github.com/edx/subscriptions/pull/210).
Note: the tests are still passing with this change because the subscriptions mockstore still contains subscriptions data.