Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #435

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Oct 2, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Oct 2, 2024
@huniafatima-arbi
Copy link
Member

tests (20) workflow is pending. If it's to be removed, please ping owning team to remove this check before merging.
@BilalQamar95

@BilalQamar95
Copy link
Contributor Author

tests (20) workflow is pending. If it's to be removed, please ping owning team to remove this check before merging. @BilalQamar95

We are the owning team for this, also merging is disabled until required checks pass. I have already pinged Diana to help out with these

@BilalQamar95 BilalQamar95 merged commit 024bcdc into master Nov 7, 2024
3 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/node20-upgrade-3 branch November 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants