Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #386

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 8, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx packages @edx/frontend-platform, @edx/frontend-build, @edx/frontend-enterprise-utils

@BilalQamar95 BilalQamar95 self-assigned this Jun 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (b143955) to head (b13b1fe).
Report is 170 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files          30       30           
  Lines         593      593           
  Branches      111      111           
=======================================
  Hits          462      462           
  Misses        129      129           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review July 21, 2023 09:05
@abdullahwaheed abdullahwaheed merged commit b326c01 into master Jul 21, 2023
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/react-upgrade-to-v17 branch July 21, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants