Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate edx sphinx theme #220

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: deprecate edx sphinx theme #220

wants to merge 3 commits into from

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Aug 6, 2024 •
edited
Loading

Description:
This PR deprecated edx-sphinx-theme and replaces it with sphinx-book-theme

@huniafatima-arbi huniafatima-arbi mentioned this pull request Aug 6, 2024
Open
1 task
UsamaSadiq
UsamaSadiq requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the Python version in tox.ini and setuptools as well. Also it would be better to run make upgrade so all requirement files get updated if we're updating the Python version.
Since platform has been updated to Python 3.11, let's update this package to 3.11 or 3.12 as well.

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/deprecate-edx-sphinx-theme branch from a7ee2a8 to 6bce72a Compare October 30, 2024 18:01
@huniafatima-arbi
Copy link
Member Author

Let's update the Python version in tox.ini and setuptools as well. Also it would be better to run make upgrade so all requirement files get updated if we're updating the Python version. Since platform has been updated to Python 3.11, let's update this package to 3.11 or 3.12 as well.

@UsamaSadiq python and setuptools version is updated. Please give it a review.

Notes
  • codecov is failing in CI due to rate limit. Currently code coverage failure keeps the CI green for the visibility of other tests. Will revert is once PR is approved.
  • Will update release in changelog when the PR is approved.

@huniafatima-arbi huniafatima-arbi self-assigned this Oct 31, 2024
iamsobanjaved
iamsobanjaved reviewed Nov 6, 2024
View reviewed changes
.github/workflows/upgrade-python-requirements.yml
@@ -17,7 +17,7 @@ jobs:

strategy:
matrix:
python-version: ["3.8"]
python-version: ["3.12"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python requirements upgrade should be done on same version as of edx-platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved left review comments

@UsamaSadiq UsamaSadiq Awaiting requested review from UsamaSadiq

Requested changes must be addressed to merge this pull request.

Assignees

@huniafatima-arbi huniafatima-arbi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huniafatima-arbi @UsamaSadiq @iamsobanjaved