Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers with inline italics don't show up properly in the TOC. #160

Closed
marcus-darden opened this issue Mar 14, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@marcus-darden
Copy link

Describe the bug
There was a top-level header (single #) that had italics, and everything from the beginning of the italics to the end of the line was removed from the link in the Table of Contents.

To Reproduce
Include the following in a markdown file and build with the primer-spec:

# This is my _"Title"_

Expected behavior
Item renders well in the document body, but the TOC in the sidebar should include "Title" (preferably italicized).

@marcus-darden marcus-darden added the bug Something isn't working label Mar 14, 2022
@seshrs
Copy link
Member

seshrs commented Mar 15, 2022

Thanks for reporting, that seems like a really bad bug! Is this issue currently visible on a live spec? (Just to help me prioritize — if this can wait a bit, I'd prefer to explore and address this in a couple of weeks 😅)

@seshrs
Copy link
Member

seshrs commented Apr 7, 2022

@marcus-darden I plan to release the fix before the SP/SU 22 semester. Does that work for you? (Let me know if you need the fix sooner.)

Closing this issue (but feel free to continue to comment).

@seshrs seshrs closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants