[Code blocks][Firefox-specific] Fix dark mode colors on small screens #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seshrs
added
bug
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/145/. (Available until Thu Feb 10 2022.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug in Firefox when the screen / browser window is "small" and Primer Spec is using a dark mode theme. The issue was that the dark-colored "enhanced code block" wasn't explicitly marked as "full-width". It looks like Chrome uses a more convenient default, whereas Firefox does not.
This PR fixes the colors by making the code block container table as full-width.