-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Halloween easter egg! #157
Conversation
The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/157/. (Available until Sat May 28 2022.) |
Super cool idea! What are your thoughts about making this opt-in vs. opt-out? |
Most of the Easter-eggs in this PR are opt-in (you have to choose the “Spooky” theme). The only auto-opt-in Easter egg is updating the icons at the top of the page. I personally think it’s not intrusive, but I’m open to hearing your thoughts on if it’s too distracting. If those icon-changes are too distracting, I’m wondering how else the “Spooky” theme will be discovered. How would students know that the temporary theme is available? |
I don't think this is too distracting at all. If you'd like, you could create issues in the relevant EECS 485 repos to opt-in to all easter eggs! |
OH you meant that repos should opt-in to the Easter eggs? I initially thought that I could automatically enable this entire Easter egg on all Primer Spec pages. Do you think that’s a bit heavy-handed, and that courses should opt-in to Easter eggs? (I’m beginning to subscribe to the opt-in idea too, but I need to give it more thought.) |
I think that it's totally fine to enable easter eggs automatically! |
I changed the I also added a new easter egg animation with ghostly emoji peaking out of the margins. If you click it, it will randomly fly across the page! |
When opening and closing the settings pane, it's possible for the Halloween plugin to be inited multiple times. We need to ensure that we don't insert more than one emoji at a time.
When testing on a Windows machine, it looks like the theme preview for the |
With |
TLDR: This PR introduces a set of temporary "Halloween" easter eggs that are only enabled between Oct. 25 and Nov. 5. (The easter egg can be activated any time via a URL "hack".)
Context
I've been meaning to insert a couple of easter eggs in Primer Spec for a while now. While it's probably too late to do something for April 1, 2022, I thought I'd start by adding a few Halloween easter eggs (including a new limited-edition "Spooky" theme!)
My design goals:
?enable_halloween=1
to any Primer Spec page.Validation
Check out the new Halloween Easter egg by adding
?enable_halloween=1
to any Primer Spec page in the preview website for this PR. For instance: https://preview.sesh.rs/previews/eecs485staff/primer-spec/157/?enable_halloween=1Here are some screenshots:
On page load, the Topbar icons are modified.
New temporary subtheme in the Settings pane
'Spooky' theme (dark-only theme, and it includes some spooky fonts!)
Double-clicking on the page causes a ghost to appear!
Every few seconds, a ghostly emoji peaks from the left/right margin of the page. Clicking on it causes it to randomly fly across the page!
Feedback welcome
I'd welcome any feedback about the Halloween easter egg (or any easter egg idea really):