Add Primer Spec logo to README #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/162/. (Available until Fri May 06 2022.) |
|
Got it working!
I also discovered that GitHub supports displaying a different image-variant based on the theme (light/dark)! I'll create an issue to add this support to Primer Spec too. (EDIT: #163) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bellakiminsun designed this SVG for the theme previews in the Settings pane — I decided to repurpose the "default" theme preview into the Primer Spec logo!
I edited the SVG by hand — I learned SVG basics, used a cheatsheet and used this fiddle to help create the border for the logo 😅
Finally, I copied the styled from the awesome README in repos by Sindre Sorhus, like https://github.com/sindresorhus/Actions.
Looks like I can only preview the README changes after merging to
main😛