Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Preload FontAwesome, fix comment grammar, audit NPM packages #189

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Cleanup: Preload FontAwesome, fix comment grammar, audit NPM packages #189

merged 3 commits into from
Jul 4, 2022

Conversation

seshrs
Copy link
Member

@seshrs seshrs commented Jul 4, 2022

As title:

  • 9845df8: Preload the FontAwesome CSS to prevent the icons (settings, sidebar toggle) from flashing.
  • 69787fd: Fix the grammar of some code comments.
  • be2a10a: Run npm audit fix.

@seshrs seshrs added this to the FA 2022 milestone Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/189/.

(Available until Wed Aug 03 2022.)

@seshrs seshrs merged commit f17cc3e into develop Jul 4, 2022
@seshrs seshrs deleted the mermaid/fix branch July 4, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
FA 2022
Development

Successfully merging this pull request may close these issues.
1 participant
@seshrs