Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Simply custom print hooks #210

Merged
merged 2 commits into from
Sep 21, 2022
Merged

[Cleanup] Simply custom print hooks #210

merged 2 commits into from
Sep 21, 2022

Conversation

seshrs
Copy link
Member

@seshrs seshrs commented Sep 21, 2022

When I first implemented the hooks for handling print events, I attempted to solve the ESLint warnings without fully understanding what I was doing.

Now that I better understand how useCallback() and useEffect() work, I was able to simplify the code a bit. We also now have fewer print-handlers registered on the page, and they update less-frequently :)

@seshrs seshrs added the semver/patch Pull Request proposes "patch" change label Sep 21, 2022
@seshrs seshrs added this to the WN 2023 milestone Sep 21, 2022
@github-actions
Copy link
Contributor

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/210/.

(Available until Fri Oct 21 2022.)

@seshrs seshrs merged commit 47740df into develop Sep 21, 2022
@seshrs seshrs deleted the hooks-cleanup branch September 21, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch Pull Request proposes "patch" change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant