[Callouts] Match latest Primer styles and colors #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current Primer Spec callout colors were inspired by GitHub's dark mode colors (and were included in the original implementation #111). However, shortly after I merged the PR, GitHub updated their dark-mode callout styles!
Initially, I wasn't a fan of the new colors — they felt a bit too "flat". However, the styles have since grown on me, and I think it's time to match GitHub's styles.
This PR updates all callout colors to match the colors from GitHub's Primer Styles for their Alert component.
I also changed the demo callouts slightly to exclude italic styles.
Validation
I think the new styles are more legible, especially in dark mode.