[Hotfix] Un-garble print previews in Chrome #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If browser is Chrome, and version < 82, then remove all italics on page before printing. See #38 for further context.
Jekyll Remote Theme does not yet seem to support Jekyll 4.0. This commit is needed to fix a Travis build failure.
This was referenced Feb 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a work-around for garbled print-previews in Google Chrome: If the user's browser is Chrome, and version < 82, then remove all italicized formatting on the page before printing. The changes that enable this functionality are in 498699d.
This PR also bumps the current Primer Spec version. When this PR merges with
master, all specs that use Primer Spec v.1.1.0 will automatically be upgraded to v.1.1.1. (No further action is needed by EECS 485 / EECS 280 staff.)Validation
Visit https://eecs485staff.github.io/primer-spec/ with Google Chrome, then try generating a print preview. The preview should appear garbled.
Then visit the preview URL for this PR on Google Chrome, and try generating a print preview — it should look all right (with italics formatting removed).
Visit the preview URL from a non-Chromium browser (like Safari or Firefox). Print previews should be generated correctly, and should include italicized formatting.
/CC @rileyschnee
Closes #38, and closes #39.