include factory.js instead of .mjs on react-native #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine in principle with including this as a stopgap if it helps in Metro, but could you point me to some docs that specify this |
|
@eemeli I don't know if there is any documentation, but here is the metro commit: facebook/metro@e88322d |
|
It's frankly ridiculous that that's the best documentation that's available, but the implementation certainly appears to treat it the same way as |
|
Yeah, I agree. Thanks for merging it anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently react-native (more specifically metro) doesn't handle mjs. See: facebook/metro#535