Output JavaScript source by default, rather than JSON #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This changes the default output from stringified JSON to stringified JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, a Webpack rule using this loader needs to specify
type: 'json'to note that its output is JSON, rather than the default expectation of JavaScript source.This PR switches the loader's output to be stringified JavaScript, and adds a new option
asJSONto restore the previous JSON output.Feature-wise, this adds proper support for repeated references, as well as BigInt, Buffer, Date, Map, Set and practically any other ECMAScript value types that a YAML schema may produce.
Circular references result in
undefinedfor the inner reference; that's currently blocked by blakeembrey/javascript-stringify#34.