Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve known tags in core schema #172

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Resolve known tags in core schema #172

merged 2 commits into from
Aug 5, 2020

Conversation

eemeli
Copy link
Owner

@eemeli eemeli commented May 17, 2020

When using the core schema, if the parsed source includes one of the following explicit tags, parse it the same way as in the yaml-1.1 schema, and include the relevant tag in doc.schema.tags:

  • !!binary
  • !!omap
  • !!pairs
  • !!set
  • !!timestamp

To disable, use the option { resolveKnownTags: false } in YAML.parse*()

Todo:

  • Update documentation
  • Review option fallback for schema-specific options

If the parsed source includes one of the following, parse it the same
way as in the yaml-1.1 schema:
- !!binary
- !!omap
- !!pairs
- !!set
- !!timestamp

To disable, use the option { resolveKnownTags: false } in YAML.parse()
@eemeli eemeli added this to the yaml 2 milestone May 17, 2020
@eemeli eemeli marked this pull request as ready for review August 5, 2020 19:21
@eemeli
Copy link
Owner Author

eemeli commented Aug 5, 2020

Documentation updated. Whether options should be refactored somehow is a rather separate question, so not going to block this PR any further on that.

@eemeli eemeli merged commit 55593c4 into master Aug 5, 2020
@eemeli eemeli deleted the resolve-all-tags branch August 5, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant